From: Keir Fraser Date: Tue, 15 Jun 2010 10:35:46 +0000 (+0100) Subject: x86 hap: clean up the definition of hap_enabled(). X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~11933 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22?a=commitdiff_plain;h=9ce732580d29c02f79f2451e25dbe2bc72736c74;p=xen.git x86 hap: clean up the definition of hap_enabled(). Actually when hvm_domain.hap_enabled is true, it is already a hvm domain. Signed-off-by: Xin Li --- diff --git a/xen/arch/x86/mm/hap/p2m-ept.c b/xen/arch/x86/mm/hap/p2m-ept.c index 4fa1db4799..e0b4a2a506 100644 --- a/xen/arch/x86/mm/hap/p2m-ept.c +++ b/xen/arch/x86/mm/hap/p2m-ept.c @@ -704,7 +704,7 @@ static void ept_dump_p2m_table(unsigned char key) for_each_domain(d) { - if ( !(is_hvm_domain(d) && d->arch.hvm_domain.hap_enabled) ) + if ( !hap_enabled(d) ) continue; p2m = p2m_get_hostp2m(d); diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index b539c3093d..941ae9abb6 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -32,7 +32,7 @@ #include /* Auditing of memory sharing code? */ -#define MEM_SHARING_AUDIT 0 +#define MEM_SHARING_AUDIT 0 #if MEM_SHARING_AUDIT static void mem_sharing_audit(void); @@ -42,12 +42,9 @@ static void mem_sharing_audit(void); # define mem_sharing_audit() do {} while(0) #endif /* MEM_SHARING_AUDIT */ - -#define hap_enabled(d) \ - (is_hvm_domain(d) && paging_mode_hap(d)) #define mem_sharing_enabled(d) \ (is_hvm_domain(d) && (d)->arch.hvm_domain.mem_sharing_enabled) - + #undef mfn_to_page #define mfn_to_page(_m) __mfn_to_page(mfn_x(_m)) #undef mfn_valid diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 79ae915711..e8f5282e66 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1729,8 +1729,7 @@ int p2m_init(struct domain *d) p2m->get_entry_current = p2m_gfn_to_mfn_current; p2m->change_entry_type_global = p2m_change_type_global; - if ( is_hvm_domain(d) && d->arch.hvm_domain.hap_enabled && - (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) ) + if ( hap_enabled(d) && (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) ) ept_p2m_init(d); return 0; diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 2cadef8e94..1c1112dc96 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -29,8 +29,6 @@ #include #include -#define hap_enabled(d) (is_hvm_domain(d) && (d)->arch.hvm_domain.hap_enabled) - /* Printouts */ #define PAGING_PRINTK(_f, _a...) \ debugtrace_printk("pg: %s(): " _f, __func__, ##_a) diff --git a/xen/include/asm-x86/hvm/domain.h b/xen/include/asm-x86/hvm/domain.h index 4d68d4b7f4..c43d9c3854 100644 --- a/xen/include/asm-x86/hvm/domain.h +++ b/xen/include/asm-x86/hvm/domain.h @@ -98,5 +98,7 @@ struct hvm_domain { }; }; +#define hap_enabled(d) ((d)->arch.hvm_domain.hap_enabled) + #endif /* __ASM_X86_HVM_DOMAIN_H__ */